On Wed, Apr 27, 2011 at 06:55:55PM +0300, Alon Levy wrote: > replace everywhere it is needed for xspice - places left out are ifdefed > out later based on the same define mentioned in qxl.h, XSPICE. > > note: leave spaces between function name and open paren? > > note2: ioport_write is added at the end of the file because the xspice > implementation > will need access to the qxl_screen_t typedef, defined earlier in qxl.h .
I think this note isn't relevant to this patch. > diff --git a/src/qxl.h b/src/qxl.h > index 99dfecf..9683966 100644 > --- a/src/qxl.h > +++ b/src/qxl.h > @@ -335,4 +335,8 @@ void * qxl_allocnf (qxl_screen_t > *qxl, > unsigned long size); > int qxl_garbage_collect (qxl_screen_t *qxl); > > +#ifndef XSPICE > +#define ioport_write(qxl, port, val) outb(qxl->io_base + port, val) > +#endif Since the beginning of the patch series is just cleanups/preparation for the real XSPICE work, I wouldn't put the #ifndef in this one. Also I'd prefer to have a real static function here instead of a #define Christophe
pgpzLXoy6SUOU.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
