On Wed, Jun 22, 2011 at 06:12:42PM +0300, Uri Lublin wrote: > On 06/22/2011 12:09 PM, Christophe Fergeau wrote: > >Check both in configure.ac (after checking if we need to rebuild > >the marshalling files) and in the python script using pyparsing > >(for people modifying .proto files in tarballs) > > I'm ok with this patch (aka ack). > > Just wanted to note that the condition is not accurate/sufficient, > for example pyparsing is also needed to build the server if > generated* files are missing
Yeah, I didn't want to test for all these files, so I picked one at random ;) If it's missed by configure, the python code will catch it and throw a nicer error message. > or if spice.proto is modified. Also if > client/generated_marshallers.cpp does not exist but > server/generated* exist and only the server is being built, then > there is no need for pyparsing. Good point, it would probably have been slightly better to test for files in server/ given that building the client is optional. But yeah, in real life I expect all files or none to be present. Christophe
pgpXilsHvS10j.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
