On Mon, Jan 23, 2012 at 01:19:51PM +0100, Christophe Fergeau wrote: > On Mon, Jan 23, 2012 at 03:17:08AM -0800, Marc-André Lureau wrote: > > configure.ac | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > New commits: > > commit c5cf7fb3bc4b48ee10c8128d4f2670f870fedad8 > > Author: Marc-Andr?? Lureau <[email protected]> > > Date: Mon Jan 23 00:54:42 2012 +0100 > > > > build: use AM_GLIB_GNU_GETTEXT > > > > For some unknown reason, this set DATADIRNAME='share' on Windows, > > which is what is expected. > > > > Although some people say only IT_PROG_INTLTOOL is necessary, it gets > > the path wrong in this case too. > > > > diff --git a/configure.ac b/configure.ac > > index 2dd9e9d..d7dd1c0 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -12,11 +12,11 @@ LT_INIT > > AM_MAINTAINER_MODE > > > > IT_PROG_INTLTOOL([0.40.0]) > > Calling IT_PROG_INTLTOOL before setting up the GETTEXT stuff is unusual, > most package start by setting GETTEXT_PACKAGE/AC_SUBSTing it, and then they > call IT_PROG_INTLTOOL. Maybe if you put the IT_PROG_INTLTOOL after, you > will no longer need to call AM_GLIB_GNU_GETTEXT?
Yeah, you really don't want to be calling both IT_PROG_INTLTOOL *and* AM_GLIB_GNU_GETTEXT in the same configure.ac script. It causes a real mess which prevents users to overriding the install locations with make variables, or configure flags. We had this problem in virt-viewer for a while, until we killed off the call to AM_GLIB_GNU_GETTEXT. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
