On Wed, 2014-12-17 at 11:09 +0100, Christophe Fergeau wrote: > On Tue, Dec 16, 2014 at 06:11:05PM +0100, Marc-André Lureau wrote: > > There are a few things that should be common to all wrong authentication > > cases. Let's put them all in the same function. > > Fwiw, this one would have deserved some splitting (introduce the new > function and use it where it's already used, and then use it in a new > place) to avoid having code movement + some not really needed > reindenting + functional change all in the same commit.
Also, "factorize" is probably not the word you want here. Perhaps "Refactor". Jonathon _______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
