On Fri, Jan 23, 2015 at 09:45:49AM -0500, Marc-André Lureau wrote: > Hi > > ----- Original Message ----- > > Calling spice_session_set_shared_dir() with a NULL argument will trigger > > a runtime warning. g_get_user_special_dir(G_USER_DIRECTORY_PUBLIC_SHARE) > > will return NULL if (for example) ~/.config/user-dirs.dirs is missing, > > and this is the default value for the "shared-dir" property which is set > > upon SpiceSession construction. This means we could end up calling > > spice_session_set_shared_dir() with a NULL parameter when instantiating > > a SpiceSession instance. > > I would say it is a fine warning. I am not sure we want to hardcode the > Public path here.
The alternative is to cope with a NULL public path, which seems to be fine actually. Getting a runtime warning when you run remote-viewer in a setup which does not match exactly the one of the developers, especially when you don't use a webdav channel is not very nice if we can avoid it. Christophe
pgpNl6uSFEHr4.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
