Hi On Tue, Aug 30, 2016 at 3:24 PM Christophe Fergeau <[email protected]> wrote:
> Another option would be to ship pkg.m4 from pkg-config 0.29 in > spice-gtk/m4/, though I don't understand how AC_SUBST was made unneeded, > so maybe that's not enough (?) > m4 should be enough, however it seems that AC_SUBST of _CFLAGS & _LIBS has been there forever. But it was changed in https://cgit.freedesktop.org/pkg-config/commit/?id=b1584b5aaf9ce396e61599caff2b5e15f01daf91 Now I don't get what autofoo magic put them in the subst list, but it works. My comment was based on https://autotools.io/pkgconfig/pkg_check_modules.html doc, which is usually a solid reference, but here I don't know what backs the 0.24... So, I think we could simply remove the prereq. > Christophe > > On Tue, Aug 30, 2016 at 12:52:43PM +0200, Christophe Fergeau wrote: > > On Fri, Aug 19, 2016 at 09:35:09PM +0400, [email protected] > wrote: > > > From: Marc-André Lureau <[email protected]> > > > > > > So we can drop the AC_SUBST for _CFLAGS & _LIBS variable (since 0.24 > > > but there is no clean way to check that before PKG_PREREQ in 0.29, > > > released last year) > > > > > > Signed-off-by: Marc-André Lureau <[email protected]> > > > --- > > > configure.ac | 26 ++++---------------------- > > > 1 file changed, 4 insertions(+), 22 deletions(-) > > > > > > diff --git a/configure.ac b/configure.ac > > > index 9b2351d..1e27202 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -12,6 +12,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 -Wall -Werror > -Wno-portability]) > > > m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) > > > LT_INIT([disable-static win32-dll]) > > > AM_MAINTAINER_MODE > > > +m4_ifndef([PKG_PREREQ], > > > + [m4_fatal([must install pkg-config 0.29 or later before > running autoconf/autogen])]) > > > > NACK to that bit, as Victor's testing showed, it's not that widespread > > yet. Maybe something PKG_PREREQ-like can be built using $(pkg-config > > --version) and m4_version_compare(), alternatively, we could just assume > 0.24 is always present. > > Or just revert this patch. > > > > Christophe > > > _______________________________________________ > Spice-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/spice-devel > -- Marc-André Lureau
_______________________________________________ Spice-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/spice-devel
