Re: [Spice-devel] [PATCH spice 1/3] Do not use gstreamer in default codecs if not available

[Victor Toso]

Hi,

On Tue, Nov 15, 2016 at 06:44:58PM +0100, Pavel Grunt wrote:
> On Tue, 2016-11-15 at 18:32 +0100, Victor Toso wrote:
> > Ii does as it will end the parser on ';' -- gstreamer bits will be
> > lost
>
> Check parse_video_codecs(), it is called on a string of pairs
> ENCODER:CODEC separated by semicolons
>
> Regex:
> {;*[0-9a-zA-Z_]*:[0-9a-zA-Z_]*;*}*
>
> The function first skips ;* after that return NULL if '\0' and then it
>  tries to scan the pair. In the end it return pointer to the next
> potential pair
>
> Pavel

My bad. I should have tested properly. I'll be more careful in the
future.

Cheers,
  toso

>
> >
> > > 
> > > Thanks,
> > > Pavel
> > > 
> > > > Maybe
> > > > 
> > > > 
> > > > #if defined(HAVE_GSTREAMER_1_0) || defined(HAVE_GSTREAMER_0_10)
> > > > #define GSTREAMER_CODECS
> > > > ";gstreamer:mjpeg;gstreamer:h264;gstreamer:vp8"
> > > > #else
> > > > #define GSTREAMER_CODECS ""
> > > > #endif
> > > > static const char default_video_codecs[] = "spice:mjpeg"
> > > > GSTREAMER_CODECS;
> > > > 
> > > > 
> > > > Frediano
> > > 
> > > _______________________________________________
> > > Spice-devel mailing list
> > > Spice-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/spice-devel

signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel