Hi,

On Thu, Dec 01, 2016 at 06:17:41PM +0200, Uri Lublin wrote:
> On 11/30/2016 07:50 PM, Victor Toso wrote:
> > From: Victor Toso <m...@victortoso.com>
> >
> > Failing to get playback or record volume async on startup is very
> > common making this warning too worrisome for users.
> >
> > If the audio back-end does not cache the last volume used or if this
> > is the first time the application is launched, this message will be
> > seen.
> >
> > Signed-off-by: Victor Toso <victort...@redhat.com>
>
> Hi Victor,
>
> OK, but (see below)
>
> > ---
> >  src/channel-main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/channel-main.c b/src/channel-main.c
> > index 72ca712..e632c8e 100644
> > --- a/src/channel-main.c
> > +++ b/src/channel-main.c
> > @@ -1171,7 +1171,7 @@ static void audio_playback_volume_info_cb(GObject 
> > *object, GAsyncResult *res, gp
> >                                                        &volume, &error);
> >      if (ret == FALSE || volume == NULL || nchannels == 0) {
> >          if (error != NULL) {
> > -            g_warning("Failed to get playback async volume info: %s", 
> > error->message);
> > +            spice_debug("Failed to get playback async volume info: %s", 
> > error->message);
>
> I see SPICE_DEBUG is used in lines above/below.
>
> Uri.

Nowadays they should be very similar.

SPICE_DEBUG: src/spice-util.h, uses g_debug()
spice_debug: spice-common/common/log.h uses g_log()

I think I removed all SPICE_DEBUG in the past while trying to improve
the logs...

For now, to keep coherence I can change to the uppercase one before
pushing (if acked)

Cheers,

>
> >              g_error_free(error);
> >          } else {
> >              SPICE_DEBUG("Failed to get playback async volume info");
> > @@ -1227,7 +1227,7 @@ static void audio_record_volume_info_cb(GObject 
> > *object, GAsyncResult *res, gpoi
> >      ret = spice_audio_get_record_volume_info_finish(audio, res, &mute, 
> > &nchannels, &volume, &error);
> >      if (ret == FALSE || volume == NULL || nchannels == 0) {
> >          if (error != NULL) {
> > -            g_warning("Failed to get record async volume info: %s", 
> > error->message);
> > +            spice_debug("Failed to get record async volume info: %s", 
> > error->message);
> >              g_error_free(error);
> >          } else {
> >              SPICE_DEBUG("Failed to get record async volume info");
> > 
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to