Hi, On Fri, Mar 10, 2017 at 09:09:03AM +0100, Pavel Grunt wrote: > On Thu, 2017-03-09 at 10:13 +0100, Victor Toso wrote: > > From: Victor Toso <[email protected]> > > > > * directsoundsrc doesn't support IDirectSoundBuffer_SetVolume > > > > This was fixed by 1b564bfb8b0db in gst-plugins-bad, see: > > https://bugzilla.gnome.org/show_bug.cgi?id=744383 > > > > * pulsesrc doesn't support volume property, it's all coming! > > > > This was fixed by 1f4bb687940f87a0 in gst-plugins-good, see: > > https://bugzilla.gnome.org/show_bug.cgi?id=595055 > > > > Signed-off-by: Victor Toso <[email protected]> > > --- > > src/spice-gstaudio.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/src/spice-gstaudio.c b/src/spice-gstaudio.c > > index 1d96c77..014c3a5 100644 > > --- a/src/spice-gstaudio.c > > +++ b/src/spice-gstaudio.c > > @@ -430,9 +430,6 @@ static void record_volume_changed(GObject > > *object, GParamSpec *pspec, gpointer d > > vol = 1.0 * volume[0] / VOLUME_NORMAL; > > SPICE_DEBUG("record volume changed to %u (%0.2f)", volume[0], > > 100*vol); > > > > - /* TODO directsoundsrc doesn't support > > IDirectSoundBuffer_SetVolume */ > > - /* TODO pulsesrc doesn't support volume property, it's all > > coming! */ > > - > > if (GST_IS_BIN(p->record.src)) > > e = gst_bin_get_by_interface(GST_BIN(p->record.src), > > GST_TYPE_STREAM_VOLUME); > > else > > @@ -441,7 +438,7 @@ static void record_volume_changed(GObject > > *object, GParamSpec *pspec, gpointer d > > if (GST_IS_STREAM_VOLUME(e)) > > gst_stream_volume_set_volume(GST_STREAM_VOLUME(e), > > GST_STREAM_VOLUME_FORMAT_CUBIC, vol); > > else > > - g_warning("gst lacks volume capabilities on src (TODO)"); > > + g_warning("gst lacks volume capabilities on src"); > > So this warnings should not be reached when there is a recent > gstreamer ?
Yes, well, the focus of the TODO above was the windows client with
directsoundsrc and linux client with pulsesrc. If a client is using
alsasrc for instance, it does not have this capabilities and this
warning will be reached.
>
> >
> > g_object_unref(e);
> > }
> > @@ -467,7 +464,7 @@ static void record_mute_changed(GObject *object,
> > GParamSpec *pspec, gpointer dat
> > if (GST_IS_STREAM_VOLUME (e))
> > gst_stream_volume_set_mute(GST_STREAM_VOLUME(e), mute);
> > else
> > - g_warning("gst lacks mute capabilities on src: %d (TODO)",
> > mute);
> > + g_warning("gst lacks mute capabilities on src: %d", mute);
> >
> > g_object_unref(e);
> > }
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/spice-devel
