On Thu, Jun 08, 2017 at 12:36:49PM +0200, Victor Toso wrote: > > In this case, it seems the user could trigger this warning by sending > > an invalid codec type in a SpiceMsgDisplayStreamCreate message? > > Wouldn't that be a bug? As client has capabilities to explicit say to > Spice which video codecs it can handle Spice shouldn't try to create a > video stream with unsupported video codec.
A bug in which component? I consider data coming from the network as "user data", as a well-behaved client should not do that, but we could be fed anything from buggy, hostile, ... clients. If spice-server code does not enforce that the data in this message is valid before this g_return_if_fail(), then imo the g_return_if_fail() can be triggered by user-provided data. Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
