If qxl->descriptor.type is QUIC, red_replay_data_chunks_free
frees qxl (data), so no need to free it again at the bottom
of the function.

Found by coverity.

Signed-off-by: Uri Lublin <u...@redhat.com>
---
 server/red-replay-qxl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 3c0f528bd..6172ed22e 100644
--- a/server/red-replay-qxl.c
+++ b/server/red-replay-qxl.c
@@ -523,6 +523,7 @@ static void red_replay_image_free(SpiceReplay *replay, 
QXLPHYSICAL p, uint32_t f
         break;
     case SPICE_IMAGE_TYPE_QUIC:
         red_replay_data_chunks_free(replay, qxl, 0);
+        qxl = NULL;
         break;
     default:
         spice_warn_if_reached();
-- 
2.13.3

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to