Hi ----- Original Message ----- > ping > > > > > > This protocol is intended for guest machines with assigned hardware > > devices to send encoded video and other informations that will be > > handled as a normal display by Spice.
Over which device/stream is it supposed to be used? I assume there will be a dedicated virtio-serial? It will have a fixed name? STREAM_TYPE_CAPABILITIES, what are you using it for? (If it's only one way, may not be very future-proof, if it's not, then it needs a better description on how caps are negotiated) > > > > New GPU devices are capable to capture and encode video in an > > efficient way. As the GPU in this case is assigned to the guest > > and not the host is easier if the guest do the hard job. > > > > This version of the patchset add support for sending cursor shape > > to the server. So that device is supposed to not work with QXL nor virtio-gpu device, it's worth to make this explicit. Imho it would be nice to document a little in the header. Also because you share some QXL struct :) Since you introduce a new protocol, wouldn't it be worthwhile to describe a small state machine? listing the messages that are allowed (and the direction). > > > > Frediano Ziglio (4): > > Add protocol to send streams to server > > Add a message to control guest streaming > > Add error reports from server to guest > > Add support for setting cursor shape from guest > > > > spice/Makefile.am | 1 + > > spice/stream-device.h | 147 > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 148 insertions(+) > > create mode 100644 spice/stream-device.h > > > > _______________________________________________ > Spice-devel mailing list > Spicefirstname.lastname@example.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel > _______________________________________________ Spice-devel mailing list Spiceemail@example.com https://lists.freedesktop.org/mailman/listinfo/spice-devel