On Tue, 2018-02-13 at 09:08 -0500, Frediano Ziglio wrote:
> > 
> > Also, leading / is unnecessary.
> > 
> > Signed-off-by: Lukáš Hrázký <lhra...@redhat.com>
> > ---
> >  src/unittests/.gitignore | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/unittests/.gitignore b/src/unittests/.gitignore
> > index 36548a1..e871e91 100644
> > --- a/src/unittests/.gitignore
> > +++ b/src/unittests/.gitignore
> > @@ -1 +1,4 @@
> > -/test-hexdump
> > +hexdump.sh.log
> > +hexdump.sh.trs
> > +test-hexdump
> > +test-suite.log
> 
> Would not be better, if we decide to name all tests test-XXXX, to
> exclude test-*.log and test-*.trs?

Sounds good.

> The leading / is to avoid to catch files in subdirectories, in
> this case I don't think we are going to exclude more files than
> expected ones but doesn't hurt to reduce the scope.

I see. Will add it again.

I just realized this is outdated by your renaming patch. I'll update
it.

Lukas
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to