On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote: > > > > On 14 Feb 2018, at 17:34, Christophe Fergeau <cferg...@redhat.com> wrote: > > > > On Wed, Feb 14, 2018 at 10:45:56AM -0500, Frediano Ziglio wrote: > >>> > >>> Shouldn't this go with a Makefile rule? A few lines in the log what this > >>> is about, what is the goal for having this file, ... would not hurt. > >>> > >>> Christophe > >>> > >> > >> I think this file is supposed to just help developers so should not > >> be in the Makefile. > > > > Yes, after reading various threads, it's apparently meant to be used > > together with emacs for formatting of small code blocks, it's not usable > > on the whole codebase. So a 'make clang-format' rule apparently would > > not make sense. > > > >> I think you mean that the intention should be written in the commit > >> message. > > > > Yes, knowing how it's meant to be used, why we want it in the codebase. > > Why would we NOT want it in the codebase?
I'm not saying I'm against what this patch is adding. I'm saying I'm against a commit adding something without much of a rationale in its commit log. Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
