> On 23 Feb 2018, at 11:15, Frediano Ziglio <fzig...@redhat.com> wrote:
> 
> Fields are initialized to zero if not explicitly specified which is
> actually what you usually want so there's no reason to have the
> compiler to generate warning for this.
> 
> ---
> m4/spice-compile-warnings.m4  |  1 +
> src/spice-streaming-agent.cpp | 11 ++++-------
> 2 files changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4
> index 66d7179..5f415cd 100644
> --- a/m4/spice-compile-warnings.m4
> +++ b/m4/spice-compile-warnings.m4
> @@ -108,6 +108,7 @@ AC_DEFUN([SPICE_COMPILE_WARNINGS],[
>     # So we have -W enabled, and then have to explicitly turn off...
>     gl_WARN_ADD([-Wno-sign-compare])
>     gl_WARN_ADD([-Wno-unused-parameter])
> +    gl_WARN_ADD([-Wno-missing-field-initializers])

Acked-by: Christophe de Dinechin <dinec...@redhat.com>

But maybe wait a little more to see if someone else objects?

>     # We can't enable this due to horrible spice_usb_device_get_description
>     # signature
>     gl_WARN_ADD([-Wno-format-nonliteral])
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to