On Fri, Mar 02, 2018 at 02:27:57AM -0500, Frediano Ziglio wrote: > > > > In my testing (x86_64/gcc), this had no impact on the resulting binary, > > building with/without it gives the same stripped binary save for its > > buildid. > > > > Signed-off-by: Christophe Fergeau <cferg...@redhat.com> > > Have you compiled proposed Snir plugin? > I think we are going to use soon this. > Not that is hard to add again.
Hmm, the plugin would use it in its CFLAGS/CXXFLAGS, or alternatively, it could use a symbol file. I don't think the agent binary needs it (in other words, I would keep the Makefile.am change). For what it's worth, maybe I'd change the test to use https://cgit.freedesktop.org/gstreamer/common/tree/m4/as-compiler-flag.m4 VISIBILITY_CFLAGS="" AS_COMPILER_FLAG([-fvisibility=hidden], [VISIBILITY_CFLAGS="-fvisibility=hidden"]) AC_SUBST(VISIBILITY_CFLAGS) VISIBILITY_CXXFLAGS="" if test "x$HAVE_CXX" = "xyes"; then AS_CXX_COMPILER_FLAG([-fvisibility=hidden], [VISIBILITY_CXXFLAGS="-fvisibility=hidden"]) fi AC_SUBST(VISIBILITY_CXXFLAGS) Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
