On 07/03/18 06:19, Christophe Fergeau wrote: > Hey, > > On Tue, Mar 06, 2018 at 03:00:30PM -0300, Eduardo Lima (Etrunko) wrote: >> On 06/03/18 13:37, Christophe Fergeau wrote: >>> On Tue, Mar 06, 2018 at 11:46:33AM -0300, Eduardo Lima (Etrunko) wrote: >>>> This is a preparation for meson build, which has built-in support for >>>> generating enums, but requires the template files to be renamed. It uses >>>> the basename of template files to generate the output, and in this case >>>> it would be the same file for both '.c' and '.h'. >>>> >>>> Reference http://mesonbuild.com/Gnome-module.html#gnomemkenums >>> >>> Hmm the generated files which should have the same base name are >>> currently spice-server-enums.c and spice-server-enums.h, so this is ok, >>> and from the link you gave, 'spice-server-enums' would be the first arg >>> to gnome.mkenums(). >>> Then the link you give lists 2 separate arguments for the templates, >>> c_template >>> and h_template. >>> So after reading the link, I'm not sure why this patch is needed? >>> >> >> The documentation is definitively lacking, I will provide a patch for >> that. I did not understand what was happening until I looked at the >> source code . Ideally, Meson should let us specify the name of the >> output files, but this is not the case. >> >> The declaration which failed was: >> >> spice_server_enums = gnome.mkenums('spice-server-enums', >> sources : 'spice-server.h', >> c_template : 'spice-server-enums.tmpl.c', >> h_template : 'spice-server-enums.tmpl.h') >> >> >> With the following error: >> >> Meson encountered an error in file server/meson.build, line 30, column 0: >> Tried to create target "spice-server-enums.tmpl", but a target of that >> name already exists. > > Ah ok, if a template file is specified, then the basename of the > template file is used instead of the first arg to gnome.mkenums. > Could be worth mentioning in the log that the documentation you link to > is inaccurate.
Pushed, thanks. I have also edited the commit message with extra information, as requested. -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com _______________________________________________ Spice-devel mailing list Spicefirstname.lastname@example.org https://lists.freedesktop.org/mailman/listinfo/spice-devel