> > On Thu, Mar 08, 2018 at 05:39:48AM -0500, Frediano Ziglio wrote: > > > > There are however still some issues: > > > > - the syntax is using C++20 while we state we use C++11 syntax, this > > > > is basically using C compatibility extensions. I just tried and for > > > > instance this code is not accepted on Visual C++ 2015 (not an issue > > > > at the moment); > > > > > > No, but it is annoying. Will make that obvious in the commit log. > > > > > > > I don't think that a comment on the log will make Visual C++ > > compile that code. Stating C++11 was the reason of this, not use too > > advance syntax that could have problems. > > For what it's worth, I'd be in favour of *not* using things newer than > what is in c++11 (or maybe c++14), this would give some first guideline > as to what's ok to use, and what should be avoided. > > Christophe >
I agree, when I read language version XX style I read as both: - compatibility: we don't use syntaxes newer than XX; - requirement: we don't support compilers not compatible with XX. I though this was a standard interpretation and we quickly agree on C++11 so I though nobody objected. Frediano _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
