Hi,

On 04/04/2018 06:31 PM, Victor Toso wrote:
From: Victor Toso <m...@victortoso.com>

This log was introduced in 13f5ebbf07a3 to track the situation where
the GdkCursor pointer would be invalid/NULL. That was possible if the
caller passed a NULL for rgba pointer in cursor_set().

Code has changed a bit since then it isn't necessary to log a warn in
missing comma?

the unlikely event of cursor_shape being NULL.

Signed-off-by: Victor Toso <victort...@redhat.com>
Reported-by: Frediano Ziglio <fzig...@redhat.com>
---
  src/spice-widget.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/src/spice-widget.c b/src/spice-widget.c
index 8a6b5ab..29688ab 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2652,7 +2652,6 @@ static void cursor_set(SpiceCursorChannel *channel,
g_object_get(G_OBJECT(channel), "cursor", &cursor_shape, NULL);
      if (G_UNLIKELY(cursor_shape == NULL || cursor_shape->data == NULL)) {
-        g_warn_if_reached();
          if (cursor_shape != NULL) {
              g_boxed_free(SPICE_TYPE_CURSOR_SHAPE, cursor_shape);
          }

IMHO it can be squashed with the other patch
But if not, ack.

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to