On Fri, Apr 13, 2018 at 7:16 PM, Frediano Ziglio <fzig...@redhat.com> wrote:

> >
> > Limited the installation of the driver to Windows 8 and up
> > in order to prevent false driver installation on unsupported OSes
> > which lead to BSODs.
> >
> > Signed-off-by: Basil Salman <ba...@daynix.com>
> > Signed-off-by: Sameeh Jubran <sam...@daynix.com>
> > ---
> >  qxldod/qxldod.inx | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/qxldod/qxldod.inx b/qxldod/qxldod.inx
> > index 180275d..5c08305 100755
> > --- a/qxldod/qxldod.inx
> > +++ b/qxldod/qxldod.inx
> > @@ -35,9 +35,9 @@ QxlDod_Files_Driver = 12
> >  ;
> >
> >  [Manufacturer]
> > -%RHEL%=RHEL,NT$ARCH$
> > +%RHEL%=RHEL,NT$ARCH$.6.2
> >
> > -[RHEL.NT$ARCH$]
> > +[RHEL.NT$ARCH$.6.2]
> >  %RHELQxl.DeviceDesc% = QxlDod_Inst, PCI\VEN_1B36&DEV_0100&SUBSYS_
> 11001AF4
> >
> >  [QxlDod_Files_Driver]
>
> Off topic: as an extra safety, cannot the driver check the version of
> Windows?
>
This can be done in the driver too, however, I think this would be
superfluous as the driver must be installed using the inf file which
prevents this scenario in the first place.

>
> Frediano
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to