On 12/16/18 2:39 PM, Frediano Ziglio wrote:
The test uses both GLib and pixman libraries.
This does not seem to affect Linux but make the test fails under Windows.

Hi,

Looks good, with a comment.


Signed-off-by: Frediano Ziglio <[email protected]>
---
  tests/Makefile.am | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 926ac99..650c4c1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -58,11 +58,15 @@ test_region_SOURCES = \
        $(NULL)
  test_region_CFLAGS =                  \
        -I$(top_srcdir)                 \
+       $(GLIB2_CFLAGS)                 \
+       $(PIXMAN_CFLAGS)                \
        $(SPICE_COMMON_CFLAGS)          \

Both GLIB2_CFLAGS and PIXMAN_CFLAGS are included in
SPICE_COMMON_CFLAGS.

        $(PROTOCOL_CFLAGS)              \
        $(NULL)
  test_region_LDADD =                                   \
        $(top_builddir)/common/libspice-common.la       \
+       $(GLIB2_LIBS)                                   \
+       $(PIXMAN_LIBS)                                  \

These are missing.
Maybe add $(SPICE_COMMON_LIBS) instead ?

Or alternatively if not all SPICE_COMMON_CFLAGS/LIBS are
needed you can remove SPICE_COMMON_CFLAGS above.

Uri.

        $(NULL)
# Avoid need for python(pyparsing) by end users


_______________________________________________
Spice-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to