On Fri, May 24, 2019 at 12:42:50PM +0200, Gerd Hoffmann wrote: > There is no good reason to flood the kernel log with a WARN > stacktrace just because someone tried to mmap a prime buffer.
Yeah no userspace triggerable dmesg noise above debug level. > > Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Daniel Vetter <[email protected]> > --- > drivers/gpu/drm/qxl/qxl_prime.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_prime.c b/drivers/gpu/drm/qxl/qxl_prime.c > index 114653b471c6..7d3816fca5a8 100644 > --- a/drivers/gpu/drm/qxl/qxl_prime.c > +++ b/drivers/gpu/drm/qxl/qxl_prime.c > @@ -77,6 +77,5 @@ void qxl_gem_prime_vunmap(struct drm_gem_object *obj, void > *vaddr) > int qxl_gem_prime_mmap(struct drm_gem_object *obj, > struct vm_area_struct *area) > { > - WARN_ONCE(1, "not implemented"); > return -ENOSYS; > } > -- > 2.18.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Spice-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/spice-devel
