On Sun, 7 Dec 2025 at 12:20, Nicholas Vinson <[email protected]> wrote: > > When building with g++-16, the build fails with the following error: > > server/tests/test-display-base.cpp:809:5: error: either all initializer > clauses should be designated or none of them should be > > This is because g++-16 defaults to c++20 and when using designated > initializers with c++20, you don't wrap anonymous union fields with braces. > > Nicholas Vinson (2): > m4/spice-compile-warnings.m4: disable -Wmissing-braces > test-display-base.cpp: adjust designated init. > > m4/spice-compile-warnings.m4 | 1 + > server/tests/test-display-base.cpp | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) >
The CI is not that happy. I added some commit to make it pass: - missing AUTHORS for "make syntax-check" https://gitlab.freedesktop.org/fziglio/spice/-/commit/fb018b3fbb26f38b2ffb0ee569d4aafc287fc738 - too old Fedora (not related to these changes) https://gitlab.freedesktop.org/fziglio/spice/-/commit/a4525e204ef8b7e3beb3709823029e27de633d7a - compatibility with pretty old GCC https://gitlab.freedesktop.org/fziglio/spice/-/commit/6a2c24fd5c088cb3b016a40965882e98f010b583 Do they sound good? I suppose the compatibility one could be merged. Regards, Frediano
