Izik Eidus wrote: > Hi, this patch should fix the issues with remote X and spice. > > This patch should fix the issues, it is made for the master branch, > I will see if it can be applied to 0.4 stable branch and if not will > make another one for that branch. > > > Thanks >
Thanks for the patch. > > > + connection_fd = ConnectionNumber(x_display); > + if (getsockname(connection_fd, &sock_addr, &sock_len)) { > + x_shm_avail = false; > + } else { > + if (XShmQueryExtension(x_display) && sock_addr.sa_family == AF_UNIX) > { > + x_shm_avail = true; > + } else { > + x_shm_avail = false; > + } > All look good, please just simplify this by if (!getsockname(connection_fd, &sock_addr, &sock_len) && XShmQueryExtension(x_display) && sock_addr.sa_family == AF_UNIX) { x_shm_avail = true; } > + } ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Spice-space-devel mailing list Spice-space-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spice-space-devel