On 11/15/12 09:58, James Turner wrote: > When I submitted the updated port to the OpenBSD mailing list I had the > following build warning pointed out that I didn't previously notice: > > ../lib/events/events_network.c:222: warning: incompatible implicit > declaration of built-in function 'memset' > > On OpenBSD, the FD_ZERO macro uses memset so, events_network.c needs: > > #include <string.h> > > to remove the warning. I wish I noticed this before the release, but the > warning didn't jump out at me from the rest of the compilation output.
This is a bug in OpenBSD -- <sys/select.h> is specified as providing FD_ZERO and no caveats are mentioned about also needing to include <string.h>: http://pubs.opengroup.org/onlinepubs/9699919799/ > I'm not sure if this is a header worth including just in case or > something I will just have to patch in my port. Either way it's probably > not worth doing another point release, I can always remove the patch if > you decide to include the header at a later date. I'm not going to add an #include which POSIX doesn't require. Whether you add a patch to spiped in the OpenBSD ports tree or fix OpenBSD or simply ignore the warning is entirely up to you. :-) > Thanks again for spiped and especially tarsnap! You're welcome! Thanks for helping to make them more widely used. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
