Revision: 1111
Author:   anodos
Date:     2006-05-04 09:29:35 -0700 (Thu, 04 May 2006)
ViewCVS:  http://svn.sourceforge.net/spring-rich-c/?rev=1111&view=rev

Log Message:
-----------
Refactored FormModel.hasProperty to FormModel.hasValueModel to avoid confusion 
(see RCP-334)

Modified Paths:
--------------
    
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/FormModel.java
    
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/support/AbstractFormModel.java
    
trunk/spring-richclient/support/src/main/java/org/springframework/binding/validation/support/RulesValidator.java
Modified: 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/FormModel.java
===================================================================
--- 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/FormModel.java
       2006-05-04 13:10:44 UTC (rev 1110)
+++ 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/FormModel.java
       2006-05-04 16:29:35 UTC (rev 1111)
@@ -101,7 +101,7 @@
     /**
      * Returns true if the form has a value model for the provided property 
name.
      */
-    boolean hasProperty(String formProperty);
+    boolean hasValueModel(String formProperty);
 
     /**
      * Commits any changes buffered by the form property value models into the

Modified: 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/support/AbstractFormModel.java
===================================================================
--- 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/support/AbstractFormModel.java
       2006-05-04 13:10:44 UTC (rev 1110)
+++ 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/form/support/AbstractFormModel.java
       2006-05-04 16:29:35 UTC (rev 1111)
@@ -255,7 +255,7 @@
             dirtyUpdated();
     }
 
-    public boolean hasProperty(String formProperty) {
+    public boolean hasValueModel(String formProperty) {
         return propertyValueModels.containsKey(formProperty);
     }
 
@@ -354,7 +354,7 @@
     public ValueModel add(String formProperty, ValueModel valueModel) {
         // XXX: this assert should be active but it breaks the 
         // code in SwingBindingFactory#createBoundListModel
-        //Assert.isTrue(!hasProperty(formProperty), "A property called '" + 
formProperty + "' already exists.");
+        //Assert.isTrue(!hasValueModel(formProperty), "A property called '" + 
formProperty + "' already exists.");
         if (valueModel instanceof BufferedValueModel) {
             ((BufferedValueModel)valueModel).setCommitTrigger(commitTrigger);
         }

Modified: 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/validation/support/RulesValidator.java
===================================================================
--- 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/validation/support/RulesValidator.java
    2006-05-04 13:10:44 UTC (rev 1110)
+++ 
trunk/spring-richclient/support/src/main/java/org/springframework/binding/validation/support/RulesValidator.java
    2006-05-04 16:29:35 UTC (rev 1111)
@@ -95,7 +95,7 @@
                     for (Iterator i = rules.iterator(); i.hasNext();) {
                         PropertyConstraint validationRule = 
(PropertyConstraint)i.next();
                         if (propertyName == null) {
-                            if 
(formModel.hasProperty(validationRule.getPropertyName())) {
+                            if 
(formModel.hasValueModel(validationRule.getPropertyName())) {
                                 checkRule(validationRule);
                             }
                         }


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
spring-rich-c-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spring-rich-c-cvs

Reply via email to