Dear authors,
I have a few comments on your draft "Distribute SRv6 Locator by DHCP".
* Section 4.1, the IA_SRV6_LOCATOR option is a new DHCPv6 option introduced by
this draft, I suggest to provide an explicit list of DHCP messages in which
this new DHCPv6 option can be carried in. A typo needs to be fixed, s/Identify
Association/Identity Association, there are three places for this typo.
* Section 4.2, the field definition for "IALocator-Options" is as following:
" - IALocator-Options: Options associated with this SRv6 locator.
A variable-length field (28 octets less than the value in the
Option-Len field)."
It defines some options associated with this SRv6 locator can be placed here, I
suggest to provide an explicit list of options if possible.
Furthermore, it says the length of IALocator-Options is "28 octets less than
the value in the Option-Len field", however the length of SRv6-Locator is
between 1 octet and 16 octets, it seems to me the length of IALocator-Options
is ("Option-Len" - 12 - "length of SRv6-Locator") but not ("Option-Len" - 28).
* Section 4.2, there are four 1-octet fields LB-Len, LN-Len, Fun-Len, and
Arg-Len defined for the IA SRv6 Locator Option. As I understand it, the value
of these fields can't be larger than 128, if that's the case, I suggest to add
value range for each of these fields and specify how to handle it if the value
is over the range.
* Section 5.1, it says "Upon receiving the Release message, the server removes
the lease and frees the locator...", suggest to add normative language MUST
into this sentence, that means it should read "Upon receiving the Release
message, the server MUST remove the lease and frees the locator...".
* Section 5.2, it says "In a message sent by a client to a server, the
preferred-lifetime and valid-lifetime fields SHOULD be set to 0", why SHOULD
but not MUST? Within the next paragraph it says "The client SHOULD NOT send an
IA SRv6 Locator option with 0 in the "LB-Len" and "LN-Len" fields", why SHOULD
NOT but not MUST NOT?
* Section 5.4, it says "After receiving the DHCPv6 Release and Decline messages
from the client...", suggest to replace "and" with "or", that means it should
read "After receiving the DHCPv6 Release or Decline messages from the
client...".
Hope these comments can help to improve this draft.
Best Regards,
Xiao Min
_______________________________________________
spring mailing list -- spring@ietf.org
To unsubscribe send an email to spring-le...@ietf.org
