Dear Linda, Happy New Year! Thank you for your thorough review and valuable comments on draft-ietf-spring-dhc-distribute-srv6-locator-dhcp. We have addressed all your comments inline with [co-authors] and incorporated the updates in version draft-ietf-spring-dhc-distribute-srv6-locator-dhcp-13.
B.R. Weiqiang Cheng From: Linda Dunbar via Datatracker Date: 2025-11-19 02:46 To: [email protected] CC: draft-ietf-spring-dhc-distribute-srv6-locator-dhcp.all; last-call; spring Subject: [spring] draft-ietf-spring-dhc-distribute-srv6-locator-dhcp-11 ietf last call Genart review Document: draft-ietf-spring-dhc-distribute-srv6-locator-dhcp Title: Distribute SRv6 Locator by DHCP Reviewer: Linda Dunbar Review result: Almost Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-spring-dhc-distribute-srv6-locator-dhcp-?? Reviewer: Linda Dunbar Review Date: 2025-11-18 IETF LC End Date: 2025-11-25 IESG Telechat date: Not scheduled for a telechat Summary: Major issues: Section 3 states BRAS and CPE are in different administrative domains. But Section 5.2 assumes BRAS can advertise routes using IGP inside the SR domain. This is contradicting: a BRAS cannot advertise in a domain it does not belong to. [Co-authors] Got it. The statement about different administrative domains has been removed. Section 5.5 has a long sentence: “The first DHCPv6 relay agent needs to record the SRv6 Locator assigned by the DHCPv6 server, including SRv6 Locator information, lifetime, etc.” Questions: - Why must a relay record the lifetime if BRAS/server already does? [Co-authors] When the Relay agent stores entries of the locator, it acts similarly to the server and also requires lifetime management. - What happens if the relay reboots? [Co-authors] This depends on the implementation. Typically, relays have primary/backup mechanisms or store entries in a database from which they can be recovered. If the relay has no entries at all, it needs to wait for the client to renew in order to rebuild the entries. For BRAS side, user entry management is usually in place, and there needs to be a mechanism to recover user entries after a reboot. - Does DHCPv6 server always install route? In multiple places: “MAY install a local SRv6 Locator route…” [Co-authors] Added descriptions to clarify the purpose of the route. Minor issues: - In Section 5.1, it says Figure 2, but the figure is actually Figure 4. [Co-authors] Changed to Figure 4. Nits/editorial comments: Several terms appear with inconsistent capitalization or spelling: - IA_SRv6_Locator vs IA_SRV6_LOCATOR [Co-authors] Changed to IA_SRV6_LOCATOR. - IALocator-Options vs IA_Locator-Options [Co-authors] Changed to: IA_Locator-Options. - SRv6 SID Locator length (LOC-Len) sometimes written SRv6 SID locator length. It would be good to ensure consistent capitalization and spacing across document. [Co-authors] Changed to: SRv6 SID Locator length. Grammar issues: - “Telecom providers can use its IP Metro and Backbone networks…” Should be: their networks. [Co-authors] Changed "its" to "their". - “SRv6 policies needs to be configured…” Should be: policies need [Co-authors] Changed "needs" to "need". Warm Regards, Linda Dunbar
_______________________________________________ spring mailing list -- [email protected] To unsubscribe send an email to [email protected]
