yah the weakref import in there was from some early version for some
reason I dont remember, but probably not this one. I think the
identity map being a weakvaluedictionary is fine.
the only discernable change in behavior which would occur (which I
can think of), if you go to the mapper to get() an object based on
its primary key, it has to go look it up in the database again if its
been dereferenced elsewhere. every other case I can think of where
the object has to be there, i.e. the unit of work logged a change for
it or one of its attributes, etc. involves a reference being on it
already.
anyway, it just ran through all the unit tests fine and clicking
around the zblog demo with it also seems ok, so Ive committed that,
and we'll see how that works out.
On Jan 9, 2006, at 8:57 PM, Mitch Skinner wrote:
I noticed that objectstore.py imports weakref but doesn't appear to
use
it. In the long run, I think UnitOfWork.identity_map ought to allow
objects that are otherwise unreferenced to become garbage. Is this
just
as simple as making it a WeakValueDictionary? Or would that break
some
other part of the code?
Mitch
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through
log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD
SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Sqlalchemy-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlalchemy-users
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Sqlalchemy-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlalchemy-users
