I've been looking into SQLAlchemy's test suite, and I think I've found
a bug in the test suite, which may be causing some tests not to be
run.

In test/testbase.py, the EngineAssert class has a post_exec() function
that looks like it's supposed to run through a list of assertions and
check each one against the actual SQL that was executed. But the
function contains not a single while statement! As it's written, it
will only check the first assertion in self.assert_list, instead of
all of them.

I think that line 113, "if self.assert_list is not None:", should have
been "while self.assert_list:". (That's line 113 as of SVN revision
817). That would allow the entire assertion list to get checked.

Either that, or I'm misunderstanding the purpose of
EngineAssert.post_exec(). That's always possible as well... :-)

--
Robin Munn
[EMAIL PROTECTED]
GPG key 0xD6497014
N�HY޵隊X���'���u���[�������
ަ�k��!���W�~�鮆�zk��C� [EMAIL PROTECTED],����a{���,�H��4�m���i�(��ܢo�v'

Reply via email to