On 21.02.2006., at 04:10, Michael Bayer wrote:
youre looking for the ProxyEngine : http://www.sqlalchemy.org/docs/ dbengine.myt#dbengine_proxy
(never knew it would be so popular so quick....)

great. you really thought it all!
the more I look at the code the more I'm impressed with the cleaness. Initially I was a little doubtful about the choice of module level functions as opposed to a more pure OOP style however I must admit that style considerations are secondary when things are done right.

while we are on this, if oids are percieved as an important feature (regardless of postgres discouraging their usage but this is another issue) it could
be interesting having them working with the ProxyEngine.

If I understood well the problem is that some databases have this feature optional and so without an instance of the proxy we cannot know the oid column name because if the particular engine instance disables this feature a None is expected.

It seems natural that oid_column_name would be called in the TableImpl so I don't understand why oid_column_name is called before
proxyng through ProxyTableImpl.

Or simply the comment in proxy.py is outdated and effectively the method will be called when an engine is present ?

PS: it seems that the whole thing about oids needs a refactory, for example separate the methods for the column name from that whether to use it or not
which may depend on the table non only on the engine.

--
marko


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Sqlalchemy-users mailing list
Sqlalchemy-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlalchemy-users

Reply via email to