On Aug 1, 2006, at 9:18 AM, Aaron Spike wrote: > Michael Bayer wrote: >> thats a good point. although you can use any literal name for a >> column >> name: >> >> mytable.c["somecolumn"] >> >> but if you want to go the "key" route we can, but im pretty sure >> theres >> going to be a lot of new ORM bugs that will need repairing. most >> of the >> effort with this ticket is the testing part of it. > > The obvious reason that quote=True is the right way to implement this > just hit me. Portability. Perhaps when you get back we can meet up and > discuss what needs to be done. I take direction well, but I'm too > new to > this discipline to have a clear picture. I'd be happy to help with > testing, though I do not have access to oracle.
I like quote=True because its easy to implement. but how "portable" is it? database A needs quotes for idenfier X, database B does not....i guess you just say "quote=True" and then both databases get the identifier quoted, no biggie. im inclined to just get something in there that does the job for now...the patch thats on ticket #155 is very close to whats needed. if you can try it out and maybe link to a "quote=True" keyword argument on Table and Column, make some test cases, we're in business. its definitely best for the quoting to actually take place during query compilation, as opposed to the actual string name of the column/ whatever having the quotes embedded into it. as I mentioned earlier, if you have a column name with a python-illegal identifier, you can still get to it via table.c["colname"]. also we can look into using "key" as well, particularly if you dont want to be stuck saying table.c["colname"] for a python identfier. "key" should work right now, but just hasnt had as many tests performed so may have bugs. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Sqlalchemy-users mailing list Sqlalchemy-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sqlalchemy-users
