yeah im not cool changing the compare method on ClauseList, thats a very deep place to change something which should not matter for any particular database dialect, youd have to show me what thats accomplishing. the test is more strict as an "ordered" test and theres been no issue with that as of yet.
also, i dont like the "autoseq" table being added to the "tables.py" module (nothing should be added to there which isnt globally used by many tests/all databases) and also the "autoseq" test in the "session.py" module, since its very ms-sql specific and the "test_fetchid" functionality seems better suited for the test/sql/ defaults.py test, which tests things like "autoincrement" columns and such (without getting the ORM involved). the change from "opts" to "db_opts" in testbase.py should be done in a style more consistent with what was already there... i dont see why the name has to change. DBTYPE, if not specified, should be pulled from a sqlalchemy.engine.url.URL object and not parsed..and also i dont understand why the "auto_identity_insert" flag, if its so critical to maintain compatibilty with SA's normal behavior, defaults to False. at the very least have it parsed as a URL querystring argument (see mysql.py for examples) so it can be part of the URL, i.e. "mssql://<someurl>?auto_identity_insert=True", so that the global **db_opts thing doesnt have to happen in the test suite. On Feb 11, 4:48 pm, Paul Johnston <[EMAIL PROTECTED]> wrote: > Hi, > > Can someone with committer status take a look at the following when > possible: > > #462 - Please close the ticket; I reopened for a reason that I now > realise is duff (info on ticket). > #422 - Gets more unit tests to pass for MSSQL. The patch does change the > behaviour of _ClauseList.compare so the compare is order-insensitive. I > think that is a good change semanticly, but if you disagree I can find a > different fix. > #473 - MSSQL bug fix. > > Many thanks! > > Paul --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---
