yikes, you're right - fixed in rev 2458. thanks for having a look.
On 3/28/07, Michael Bayer <[EMAIL PROTECTED]> wrote: > > are you sure thats right ? ClauseParameters doesnt have any kind of > "__getattr__" logic going on....i think the test you have there would return > False in all cases. are you sure you dont mean: > self.IINSERT = tbl.has_sequence.key in parameters[0] > has_key() has been removed in favor of just __contains__() since thats > where py2.6/3000 is headed. > > On Mar 28, 2007, at 3:16 PM, Rick Morrison wrote: > > The MSSQL module examines the parameter object, looking for whether or not > the query being executed has an explicit primary key on an autoincrementing > column. Inserting those things in MSSQL is a special mode (don't get me > started on how goofy that is...). > > The code was using "key in parmobject" to look for it; I changed it to > hasattr(), and it seems fine. Thanks for the explanation. > > Rick > > > On 3/28/07, Michael Bayer <[EMAIL PROTECTED]> wrote: > > > > > > > > > > On Mar 28, 1:15 pm, "Rick Morrison" <[EMAIL PROTECTED]> wrote: > > > Hey Mike, this looks to be related to the > > parameters-as-ClauseParameters > > > instead of Python dict() on a different thread. > > > > you mean the thing i just checked in yesterday ? OK yeah, youve > > always been getting a ClauseParameters object, its just it subclassed > > "dict". I removed that becuase the API of ClauseParameters was > > getting totally muddy and i didnt even understand how it worked > > anymore. so now its more explicit fields with their behaviors more > > clearly separated. but it still has a __getitem__ and a __contains__ > > on it and we can put keys() there as well, so what more dictlike > > behavior do you need ? > > > > > > > > I'm going to need some help or advice beating the MSSQL module into > > shape > > > with the new convention. Where does the positional / non-positional > > > specification go? I don't see it in any of the DB modules. > > > > we are usually calling "paramstyle" off the DBAPI itself to figure > > that out. that might have to change soon when I address the > > ImportError ticket. > > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---
