On Mon, 2012-08-13 at 10:59:59 -0400, Michael Bayer wrote: > very nice job understanding quite a number of SQLAlchemy APIs, this is > good work. It reminds me also of how we still have a weakness in the > Core API, that we can't add new comparison methods at the Core level > onto Column objects and such. The column_property() here is a > well-designed workaround for that. > > Ideally MutationDict would be part of SQLAlchemy, from the mutable > extension. the extension should have "mutable" versions of basic > types list, dict, set. That's a TODO and also we'd need lots of > tests.
Sounds really great (especially the ability to add comparison methods onto Column), looking forward to it. > The contains() method is addressed by allowing the "escape" argument > through: Thanks, I pushed the fix. > as for __getitem__ I don't want to expose that as a potential operator > right now, I'd rather look into a deeper change to the operator system > first so that hacks like _HStoreBinaryExpression aren't needed, then > we can figure out if there's a space for __getitem__ types of things. I decided to remove it for now, as there's get() method which works in all cases (albeit looks not as nice as using __getitem__), and I would like to keep the symmetry between Core and ORM methods. Will add it back in the future, if (when) support for it comes. Thanks for your comments! -- Audrius Kažukauskas http://neutrino.lt/
pgp8JwLxlfE5e.pgp
Description: PGP signature
