On 6/24/14, 3:32 AM, Damian Dimmich wrote: > Hello, > > I've started putting together support for JSONB - a new type > introduced with the postgres 9.4 beta here: > > https://github.com/ddimmich/sqlalchemy > > As this shares a lot with the JSON datatype I've kept the code in the > json.py file. Please let me know if you think it should have its own > file or would like me to structure the code differently. > > I've had a look through the tests and haven't found anything specify > to dialect datatypes - are there no tests for these or am I just blind? take a look at https://bitbucket.org/zzzeek/sqlalchemy/src/f10eb28d90cbf73f4757897f52bf26722f98372e/test/dialect/postgresql/test_types.py?at=master#cl-1679, that's pointing at the existing JSON tests for PG specifically.
As far as json.py it all depends on how much new code vs. shared we're talking about. If all the operator logic and such stays the same and just the data marshaling is different it is probably ok. -- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sqlalchemy. For more options, visit https://groups.google.com/d/optout.
