Great, thanks Mike, all tests pass for pg8000 without a hitch now. On Wednesday, 8 April 2015 05:12:51 UTC+1, Michael Bayer wrote: > > > > On 4/7/15 4:33 PM, Mike Bayer wrote: > > it's a test that very seldom fails in some cases no matter what, as it's > checking reference counts on objects that are expected to be garbage > collected without any cycles. A failure of this test is not strictly a > "bug", it just refers to connections or cursors that are not collected > immediately. if it is persistent and only occurs with pg8000 then there > might be some cursor cleanup issue going on. > > > 44a9820b4e02f65b3884fa2c016efc has a fix which adds explicit cleanup to a > few connection objects that are checked out and not closed, leading to the > pool._refs collection to not be empty when that particular test starts. > This is backported to 0.9 as well. > > > > > > > > On 4/7/15 3:22 PM, Tony Locke wrote: > > Hi, I found the following SQLAlchemy test fails: > > FAIL test/engine/test_pool.py::QueuePoolTest::()::test_queuepool_close > > with the stack trace: > > __________________________ QueuePoolTest.test_queuepool_close > ___________________________ > Traceback (most recent call last): > File "/home/tlocke/sqlalchemy/test/engine/test_pool.py", line 805, in > test_queuepool_close > self._do_testqueuepool(useclose=True) > File "/home/tlocke/sqlalchemy/test/engine/test_pool.py", line 854, in > _do_testqueuepool > assert not pool._refs > AssertionError: assert not set([<sqlalchemy.pool._ConnectionRecord object > at 0x7fc03cf1f4a8>, <sqlalchemy.pool._ConnectionRecord object at > 0x7fc03cf1f710>, <sqlalchemy.pool._ConnectionRecord object at > 0x7fc03cf1f5c0>]) > + where set([<sqlalchemy.pool._ConnectionRecord object at > 0x7fc03cf1f4a8>, <sqlalchemy.pool._ConnectionRecord object at > 0x7fc03cf1f710>, <sqlalchemy.pool._ConnectionRecord object at > 0x7fc03cf1f5c0>]) = pool._refs > > The versions I'm using are: > > platform linux -- Python 3.4.0 -- py-1.4.26 -- pytest-2.7.0 > > I ran it against the tip of the master branch > 72329433e78e57c8589e4797df523bb598190b64 > > and the command I ran was a straightforward: > > py.test test/engine/test_pool.py::QueuePoolTest > > I'm sure I'm doing something really obviously wrong, but I'm not sure > what, so I'd be grateful if anyone can help. Btw, it was the only test that > failed when I ran the entire suite. > > Thanks, > > Tony. > -- > You received this message because you are subscribed to the Google Groups > "sqlalchemy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To post to this group, send email to [email protected] > <javascript:>. > Visit this group at http://groups.google.com/group/sqlalchemy. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "sqlalchemy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To post to this group, send email to [email protected] > <javascript:>. > Visit this group at http://groups.google.com/group/sqlalchemy. > For more options, visit https://groups.google.com/d/optout. > > >
-- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sqlalchemy. For more options, visit https://groups.google.com/d/optout.
