Mike Bayer <mike...@zzzcomputing.com> writes: > On 01/24/2016 11:11 AM, Lele Gaifax wrote: >> I wonder whether there is an underlying reason or if it's just an oversight. > > both? the rowproxy is addressable by lots of things like strings, > Column objects. if we want to add negative index support i can accept > PRs. probably only for a major version like 1.1, 1.2 etc.
Ok. Does that mean I should target the master branch or rel_1_1? >> If the latter, should the fix go into the BaseRowProxy (C and pure Python >> version) class or into the ResultMetaData._key_fallback() method? > > negative integer indexes can be worked out in terms of the positive ones > so not sure key_fallback is necessary. Yeah, I wasn't sure about the right place to add the tweak: the latter would be simpler, since there is no C counterpart, but I think the former is the way to go. thanks&ciao, lele. -- nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia. l...@metapensiero.it | -- Fortunato Depero, 1929. -- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sqlalchemy+unsubscr...@googlegroups.com. To post to this group, send email to sqlalchemy@googlegroups.com. Visit this group at https://groups.google.com/group/sqlalchemy. For more options, visit https://groups.google.com/d/optout.
