Gaetan de Menten wrote: > Keep it as it is for now, the global extension is a no-go. There is > already enough overhead in an ORM without us needing to add more (if > we can avoid it). Besides your code is already quite inefficient as it > is. Haven't thought much about it though, so I'm not sure there is a > way to do better but I hope I'll find one.
Yes, its quite inefficient, but worked after 10 minutes ;) I had thought of a way to do it a lot better in the middle of the night last night, and when I woke up, you had already committed the same idea -- cheers! > Well, I'd personally bring the event system into the main code (not in > an ext). That way, we could get rid of the statement and automatically > detect whether the extension is needed or not. I am fine with this, the only reason I did it as an extension was to avoid having to make changes to the core, but I think the changes would be small enough that it would be worth it. Feel free to eliminate the statement if you like, and integrate this directly into the core. > One last thing: I guess it's hard to change an oldtime pythonista > like you but, as I already told you months ago, comparing types is > preferably done with isinstance nowadays. Of course! Old habits are difficult to break, thanks for the reminder. -- Jonathan LaCour http://cleverdevil.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "SQLElixir" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlelixir?hl=en -~----------~----~----~----~------~----~------~--~---
