On Mon, Sep 1, 2008 at 5:32 PM, alex bodnaru <[EMAIL PROTECTED]> wrote:
> sorry to bothering. You are definitely not bothering... Providing patches is not a bother ;-) Thanks a lot for your contributions (and sorry for the slow reply)... > i found the owned extension clashed with the newer versioned one, so > here are the patched versions for both. Could you explain briefly how they collided? Here are a couple comments (please don't take them badly, I'm just trying to be constructive here): - Could you provide patches (diffs) instead of the complete files? It makes it easier for me to see what changed exactly without having to "apply" your file in the correct place. - I don't really get how a non-callable "get_current_user" can be of any use. If it's a constant for the whole table, why even add the column? - I don't think you should special-case [ ] for column_field_names. If people want the default names, they should pass None, that's all. - I don't like the default names for the columns. What do you think of "inserted_by" (or "created_by") and "updated_by"? - Why do you re-write the record_inserter on each update? It has already been set on insert, so you don't need to write it again and again. Besides, having a select() query in a before_update extension should be avoided if possible as it will slow things down. - I try to wrap code at 80 characters. -- Gaëtan de Menten http://openhex.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "SQLElixir" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlelixir?hl=en -~----------~----~----~----~------~----~------~--~---
