Forwarding to list.
Begin forwarded message:
From: Daniel Böhringer <[EMAIL PROTECTED]>
Date: 25 April 2008 19:32:02 BST
To: Ash Berlin <[EMAIL PROTECTED]>
Subject: Re: [sqlfairy-developers] fix quoted foreign keys in SQL/
Translator/Parser/PostgreSQL.pm
X-Spam-Report: No, score=-2.6 required=5.0 bayes=0.0000
autolearn=ham version=3.2.4 on callisto.firemirror.com
tests=BAYES_00=-2.599,SPF_PASS=-0.001
p5B13FE69:~ daboe01$ diff /Users/daboe01/Desktop/test-sql-neu.pl /
Users/daboe01/Desktop/test-sql.pl
74,75d73
<
< alter table t_test2 ADD CONSTRAINT c1 FOREIGN KEY ("f_int")
REFERENCES "t_test1"("f_serial");
250c248
< is( scalar @t2_constraints, 4, "Four constraints on table" );
---
> is( scalar @t2_constraints, 3, "Three constraints on table" );
without my modification the test dies with
p5B13F803:~ daboe01$ perl /Users/daboe01/Desktop/test-sql-neu.pl
1..117
ERROR (line 60): Invalid field: Was expecting data type but
found "c1
FOREIGN KEY ("f_int") REFERENCES
"t_test1"("f_serial");" instead
ERROR (line 60): Invalid statement: Was expecting create, or
comment on
table, or comment on column, or comment on
other, or
comment, or alter, or grant, or revoke, or
drop, or
insert, or connect, or update, or set, or
select, or
copy, or readin symbol
Parse failed.
Am 25.04.2008 um 15:12 schrieb Ash Berlin:
Can we please have a patch to the test suite that fails without
this change applied, and succeeds with it?
Thanks
-ash
On 25 Apr 2008, at 09:32, Daniel Böhringer wrote:
Dear list,
in order to support uppercase foreign key target-columns
line 608 has to be changed from
parens_word_list : '(' WORD(s /,/) ')'
to
parens_word_list : '(' name_with_opt_quotes(s /,/) ')'
thanks and kind regards,
daniel boehringer
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save
$100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
--
sqlfairy-developers mailing list
sqlfairy-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
--
sqlfairy-developers mailing list
sqlfairy-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers