Grate !

I find the "amalgamation" very useful in integrating SQLite in existing source trees, compiling it using various flags together with other sources etc.

There is one thing that I always have to modify:

In function sqlite3UnixCurrentTime, comming from os_unix.c, the call to gettimeofday takes an unused parameter, a pointer to sTz.

For various reasons I have to compile using "-std=c99" flag, in which case "struct timezone" is not declared (or I didn't figured out yet a some other parameters).

In any case, I think it is fairly safe to replace
  struct timezone sTz;  /* Not used */
  gettimeofday(&sNow, &sTz);
with:
  gettimeofday(&sNow, NULL);

This may also save a little space on the stack.

From what I know the second parameter was never used on Linux; the manual page from other systems also states that if the second parameter is not null, then the behavior of the function is not specified. So it seems like a safer bet to pass NULL as the second parameter.

I'm relatively new to SQLite, and I'm quite swamped with an upcoming release of my project, so please excuse me if I didn't find out yet what is the proper way of sending this kind of "simple stupid piece of code" (patch, discussion list, private email, etc).


Cheers and many thanks for SQLite!
-iulian

[EMAIL PROTECTED] wrote:
SQLite version 3.3.14 is now available on the SQLite website
[...]


-----------------------------------------------------------------------------
To unsubscribe, send email to [EMAIL PROTECTED]
-----------------------------------------------------------------------------

Reply via email to