> Would the authors be kind to implement such optimization?
I'm not author but I believe the answer to this question is No.
Because this fix is good enough for you but may be not good for
others. Your fix gets more memory than is really needed and it can be
a problem for embedded devices.
But you're free to use your fixed version of SQLite or make your own
implementation of group_concat (by copying SQLite's code and applying
your changes), register it in your application and use it.
Pavel
On Thu, Oct 15, 2009 at 12:35 AM, ??????? ???????? <pus...@khsu.ru> wrote:
>
>
> I make use of group_concat aggregate function and I found
> it very slow, especially when there are thousands of lines per group.
> This is because it reallocates memory on each processed row.
> I changed just one line in sqlite3StrAccumAppend():
>
> szNew += N + 1
>
> to something like this:
>
> do{ szNew = szNew*2 + 1; } while (szNew <= p->nChar + N);
>
> and now group_concat works fine.
> Would the authors be kind to implement such optimization?
>
> _______________________________________________
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
_______________________________________________
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
