-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/28/2011 01:44 PM, Drake Wilson wrote: > I'm inclined to believe this nullifies the main argument against > forking os_unix.c in the absence of strong evidence to the contrary.
Here are some broken things in VFS of varying severity where fixing them may involve changing the VFS code. (Coincidentally I reported most of them.) http://www.sqlite.org/src/tktview?name=5e0423b058 http://www.sqlite.org/src/tktview?name=c060923a54 http://www.sqlite.org/src/tktview?name=d8fe6cef65 http://www.sqlite.org/src/tktview?name=0b803bff85 > essentially "subclassing" the VFS. That was also my initial reaction. However it doesn't solve the problem. In essence copying a few thousand lines of code and changing 3 of them feels wrong. Note that no one is disputing that it works. > I haven't looked as closely as Pavel, Richard, et al. presumably > have. Exactly :-) > filename-related and easily refactorable into a short stack of local > functions plus wrappers for the methods that take a filename argument, Go through the exercise of making a VFS where the only difference is that the open() call buried inside unixOpen calls a different function. Now make sure it is tested, kept up to date, works with the platform SQLite etc. It will work, but it is ugly. The question is if there is a better way. Roger -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk1sHQMACgkQmOOfHg372QQQ7QCgjyLkJHIr3wpZOfa7ANehAn0u hRkAoNS83bpoZRUoC7RZgdVIYMu0dKq9 =0SbV -----END PGP SIGNATURE----- _______________________________________________ sqlite-users mailing list sqlite-users@sqlite.org http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
