> > Index: sqlobject/main.py > > - return '\n'.join(sql) > > + return sql > > You touched main.py, and the change seems rather big - you made the > function to return a list instead of a string. For such a change I'd like > to see tests. Have you ran the test suite?
They seem big, yet the only part of sqlobject that I can tell that use the functions I changed are in sqlobject-admin. I would run the test suite and compare but as it is I get 99 failures off of svn. I do get 102 failures with my changes (I tried tracking the diff's in failures but got confused). Is there something I'm missing to get the tests up and running? --gabe ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ sqlobject-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss
