Thanks Oleg. Yeah, I'll try to be more consistent on the names and more
"spacey" as well. In general I was trying to follow the style guide,
kinda...
Also, I didn't realize that () was significantly cheaper than [], but I
suppose that's probably the case. Good point.
I'll continue to work on it.
- Sean
Oleg Broytmann wrote:
> A few comments about style...
>
> On Sat, Aug 05, 2006 at 07:39:11PM -0400, Sean McBride wrote:
>> + extraColsList = ops.get('extraColumns',[])
>
> Don't hesitate to add an additional space. We do not worry too much
> about the size of the source. ;) BTW, wouldn't it better to use () instead
> of creating a new list every time?
>
> + extraColsList = ops.get('extraColumns', ())
>
>> + gb = ops['groupBy']
>
> gb? KGB? Don't be shy to write a longer names. ;)
>
> + groupBy = ops['groupBy']
>
> + extraColumns = self.select.ops.get('extraColumns', ())
>
> Oleg.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
sqlobject-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss
