Hello!
On Tue, Jun 20, 2006 at 03:59:05PM +0200, Pau Aliagas wrote:
> SELECT t1.*
> FROM t1,
> t2 LEFT JOIN s2
> ON t2.f = t2.f, # <- sqlobject does not add this comma
> t3 LEFT JOIN s3
> ON t3.g = t2.g
> WHERE ....
> --- a/dbconnection.py 2006-06-19 10:37:21.000000000 +0200
> +++ b/dbconnection.py 2006-06-20 16:47:18.000000000 +0200
> @@ -455,11 +455,13 @@
> join_str = ' '
> join_str += self.sqlrepr(join)
> else:
> - if tables and join[0].table1:
> - join_str = ", "
> - else:
> - join_str = ' '
> - join_str += " ".join([self.sqlrepr(j) for j in join])
> + join_str = ""
> + for j in join:
> + if tables and j.table1:
> + sep = ", "
> + else:
> + sep = ' '
> + join_str += sep + self.sqlrepr(j)
Well... I have created a test myself, applied the patch and committed in
the revision 1859 to the trunk, rev. 1860 to the 0.7-branch.
The test only tests the syntax (there is a comma), it doesn't perform
the query.
Oleg.
--
Oleg Broytmann http://phd.pp.ru/ [EMAIL PROTECTED]
Programmers don't die, they just GOSUB without RETURN.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
sqlobject-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss
