On at 11:00:01PM +0400, Oleg Broytmann wrote:
> On Thu, Sep 28, 2006 at 09:16:49PM +0300, Dan Pascu wrote:
> > I think the original's poster patch is the right thing to do.
> 
>    Better to say "it could have more sense". Unfortunataly, one-line patch
> near .style.dbColumnToPythonAttr() looked for me like a quick and dirty
> hack, like a shortcut over proper SQLObject path. I could be wrong, of
> course, but that was my impression.

You've got it wrong, the one line patch is in columnFromDatabase().

>    Those who would want to make sense with the patch - welcome. You have
> already reviewed the patch. Now it is time to test it and submit tests. I
> could extend the patch to the other backends, but I certainly need a set of
> good tests.
 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
sqlobject-discuss mailing list
sqlobject-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss

Reply via email to