On Wed, Aug 08, 2007 at 08:15:11AM +0200, Johan Carlsson wrote:
> >   It's a typo. LIMIT is meaningless with COUNT, not DISTINCT (because 
> >   LIMIT
> >will be applied after COUNT and COUNT returns only one row.)
> >  
> In that cause, isn't kind of unnecessary:
> Because, limit is converted in to start/end in the __init__

   Yes, but it is not removed from self.ops and checked here.

> Hm, after revising the code I get the feeling the start/end code in the 
> post processing part of count
> isn't doing anything at all, but rather destroying the result.

   Seems like a stub for a paged view - you call .count() with start/end
and get count - start - end.

> Is there any tests for the SelectResults? I can't find any!

   There are many, though they use .select() instead of directly using
SelectResults.

Oleg.
-- 
     Oleg Broytmann            http://phd.pp.ru/            [EMAIL PROTECTED]
           Programmers don't die, they just GOSUB without RETURN.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
sqlobject-discuss mailing list
sqlobject-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss

Reply via email to