On Wed, Aug 01, 2007 at 08:28:06AM +0200, Johan Carlsson wrote:
> - if self.ops['limit'] is not NoDefault:
> - end = start + limit
> + if self.ops['limit'] not in (NoDefault, None):
> + end = start + self.ops['limit']
As far as I can see the default for "limit" in Select can be declared
None instead of NoDefault, and it will be enough to test
if self.ops['limit']:
Right? (Yes, limit 0 is the same as None.)
The change is a change in the public API... but in this particular case
I think it's ok to change the API - the change is small and it fixes a bug.
PS. Most other defaults could be None too, but it's rather bigger change in
the otherwise working code so I am not going to do this even in the trunk.
Oleg.
--
Oleg Broytmann http://phd.pp.ru/ [EMAIL PROTECTED]
Programmers don't die, they just GOSUB without RETURN.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
sqlobject-discuss mailing list
sqlobject-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss
